On Fri, Jun 28, 2019, at 1:38 PM, Martin Simmons wrote:
> >>>>> On Fri, 28 Jun 2019 09:38:02 -0400, Dan Langille said:
> > 
> > > On Jan 24, 2019, at 10:16 AM, Martin Simmons <mar...@lispworks.com> wrote:
> > > 
> > >>>>>> On Wed, 23 Jan 2019 16:33:14 -0500, Dan Langille said:
> > >> 
> > >> But there is one error:
> > >> 
> > >> ==>Entering directory /usr/home/dan/src/bacula/regress/build/src/tools
> > >> cats_test.c:533:75: error: too many arguments provided to function-like 
> > >> macro invocation
> > >>   ok(db_get_file_list(jcr, jcr->db_batch, buf, false, false, list_files, 
> > >> &j),
> > >>                                                                          
> > >> ^
> > >> ../cats/protos.h:223:9: note: macro 'db_get_file_list' defined here
> > >> #define db_get_file_list(jcr, mdb, jobids, opts, result_handler, ctx) \
> > >>        ^
> > > 
> > > Ah, yes, I see that error as well (but it doesn't stop the build because 
> > > it
> > > happens during configure).
> > > 
> > > You can fix it with this patch:
> > > 
> > > --- bacula/src/tools/cats_test.c  2017-06-06 14:21:50.222462851 +0100
> > > +++ bacula/src/tools/cats_test.c  2019-01-24 14:32:08.742302000 +0000
> > > @@ -530,7 +530,7 @@
> > >    ok(j == 1, "Check batch session records");
> > >    j = 0;
> > >    Mmsg(buf, "%lld", (uint64_t)jcr->JobId);
> > > -   ok(db_get_file_list(jcr, jcr->db_batch, buf, false, false, 
> > > list_files, &j),
> > > +   ok(db_get_file_list(jcr, jcr->db_batch, buf, DBL_NONE, list_files, 
> > > &j),
> > >       "List files with db_get_file_list()");
> > >    ok(j == 1, "Check db_get_file_list results");
> > >    /* ---------------------------------------------------------------- */
> > > 
> > 
> > Regression tests on MySQL 5.5 and MySQL 5.6 are still failing with this 
> > error.
> 
> It looks like FreeBSD's make gives more errors than GNU make, making this
> fatal.
> 
> > Is it feasible to patch the code?
> 
> Did you try the patch above?
> 
> __Martin

No, sorry, I have not.  I just posted another email about this, forgetting that 
this thread already exists.

Sorry


-- 
  Dan Langille
  d...@langille.org



_______________________________________________
Bacula-devel mailing list
Bacula-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bacula-devel

Reply via email to