Hi Kern,
I've attached the patch that I made a while ago, which still applies in git
head.
__Martin
>>>>> On Thu, 12 Dec 2019 12:49:15 +0100, Kern Sibbald said:
>
> Hello Martin,
>
> I don't use or have clang, so I will need a community contribution patch
> to resolve this.
>
> Best regards,
> Kern
>
> On 12/9/19 4:04 PM, Martin Simmons wrote:
> > It is repeatable with the default compiler (clang) on FreeBSD 11.3. The
> > error
> > happens in the "Doing make of dependencies" stage of configure, which does
> > examine cats_test.c. It looks like gcc does not report the incorrect macro
> > call as an error, but clang does.
> >
> > __Martin
> >
> >
> >>>>>> On Wed, 4 Dec 2019 18:17:34 +0100, Kern Sibbald said:
> >> Hello Dan,
> >>
> >> There seems to be a problem with your Makefile. On my system
> >> cats_test.c is never compiled. I think it is somewhat old and has not
> >> been updated to new calling sequences, but on my system it is never
> >> compiled.
> >>
> >> Best regards,
> >>
> >> Kern
> >>
> >> On 11/26/19 3:07 AM, Dan Langille wrote:
> >>> I'm seeing build errors on FreeBSD 12.
> >>>
> >>> With MySQL 5.6, 5.7, and 8.0 and PostgreSQL 11.5 and 12.1. I didn't look
> >>> at PostgreSQL 9.4-10
> >>>
> >>> They are all similar to.
> >>>
> >>>
> >>> ==>Entering directory /usr/home/dan/src/bacula/regress/build/src/tools
> >>> cats_test.c:533:75: error: too many arguments provided to function-like
> >>> macro invocation
> >>> ok(db_get_file_list(jcr, jcr->db_batch, buf, false, false,
> >>> list_files, &j),
> >>>
> >>> ^
> >>> ../cats/protos.h:226:9: note: macro 'db_get_file_list' defined here
> >>> #define db_get_file_list(jcr, mdb, jobids, opts, result_handler, ctx) \
> >>> ^
> >>> 1 error generated.
> >>> *** Error code 1
> >>>
> >>> Stop.
> >>> make[2]: stopped in /usr/home/dan/src/bacula/regress/build/src/tools
> >>> *** Error code 1
> >>>
> >>> Stop.
> >>> make[1]: stopped in /usr/home/dan/src/bacula/regress/build
> >>>
> >>> ....
> >>>
> >>>
> >>> and later:
> >>>
> >>> Compiling bpipe.c
> >>> bpipe.c:89:12: warning: unused variable 'rlimitResult' [-Wunused-variable]
> >>> int64_t rlimitResult=0;
> >>> ^
> >>> bpipe.c:88:18: warning: unused variable 'rl' [-Wunused-variable]
> >>> struct rlimit rl;
> >>> ^
> >>> 2 warnings generated.
> >>> Compiling bsnprintf.c
> >>> Compiling btime.c
> >>> Compiling cram-md5.c
> >>> Compiling crc32.c
> >>> Compiling crypto.c
> >>> crypto.c:199:1: warning: unused function 'sk_SignerInfo_new'
> >>> [-Wunused-function]
> >>> DEFINE_STACK_OF(SignerInfo);
> >>> ^
> >>> /usr/include/openssl/safestack.h:130:29: note: expanded from macro
> >>> 'DEFINE_STACK_OF'
> >>> # define DEFINE_STACK_OF(t) SKM_DEFINE_STACK_OF(t, t, t)
> >>> ^
> >>>
> >>>
> >>
> >> _______________________________________________
> >> Bacula-devel mailing list
> >> Bacula-devel@lists.sourceforge.net
> >> https://lists.sourceforge.net/lists/listinfo/bacula-devel
> >>
>
>
--- bacula/src/tools/cats_test.c 2017-06-06 14:21:50.222462851 +0100
+++ bacula/src/tools/cats_test.c 2019-01-24 14:32:08.742302000 +0000
@@ -530,7 +530,7 @@
ok(j == 1, "Check batch session records");
j = 0;
Mmsg(buf, "%lld", (uint64_t)jcr->JobId);
- ok(db_get_file_list(jcr, jcr->db_batch, buf, false, false, list_files, &j),
+ ok(db_get_file_list(jcr, jcr->db_batch, buf, DBL_NONE, list_files, &j),
"List files with db_get_file_list()");
ok(j == 1, "Check db_get_file_list results");
/* ---------------------------------------------------------------- */
_______________________________________________
Bacula-devel mailing list
Bacula-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bacula-devel
