Hi Kern, 

Kern Sibbald writes: 

> 1. They are not relative to the current CVS.

Hm, they are applying to it, or? At least I tried that.. 

> 2. They are a significant change from the current code, which is not a 
> problem 
> during the development cycle, but *is* a major problem at this point.

This I understand and I agree fully here. when 1.40 is at the end of the 
release cycle this change is too sweeping to include. But maybe for a later 
release it is ok. For so long it can be kept as local patches... 


> 3. They seem to change non-FreeBSD code -- perhaps not the functionality but 
> by adding a switch().

If that is a problem, it can also be done by using if() but I found switch() 
more suitable here. 

> On the other hand, I would suggest that you work with Jeremy Reed as his 
> patch 
> once it is appropriately tweaked is something that I could see adding to 1.40 
> because:
> 1. It is relative to the CVS 
> 2. It makes the mininum necessary changes
> 3. For the most part the changes seem to be FreeBSD specific

patch-src-findlib-create_file.c is based on his patch. I just added the 
restore of the file flags on failure, and error messages in case of 
failures. What is the problem with it and the CVS version?

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Bacula-users mailing list
Bacula-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bacula-users

Reply via email to