> patch-src-findlib-create_file.c
> Try to unset file flags of the sourcefile when the hardlink failed.
> Retry to hardlink then. If the hardlink fails then again, restore the
> file flags of the sourcefile. If the hardlink was created w/o errors,
> restore the fileflags of the sourcefile.
Why do the chflags(attr->olname, s.st_flags) "restore the fileflags of the
sourcefile" twice?
Also the first reset of the chflags() should probably have error checking
and debugging there too (specific for that). (That's what I have added to
my own code.)
> patch-src-findlib-attribs.c
> when restoring a symlink, use lchflags to restore the file flags
> defined for the symlink ("new feature")
> when restoring a hardlink, don't call chmod, chown, utime because it is
> a hardlink and don't have such attributes (as far as I know, if someone
> with more FS-foo can step up and confirm this?). Changing this
> attributes will change the sourcefiles attributes which is probably not
> what is wanted here anyway....
I don't understand this but may look closer at your code.
A hardlink is just a normal file -- it does have mode, ownership and
access and modification times. (I think maybe you just typed wrong word
above and didn't mean that.)
Also a symlink has a mode (which can be changed but probably on all BSDs
it isn't even honored), ownership and modification time (time of symlink
creation) and change time (time of last file status change). I can see all
of this easily. (I am not sure if access time ever changes as I didn't
look at source and never saw that.)
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Bacula-users mailing list
Bacula-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bacula-users
