Hi On Jan 5, 2011, at 10:41 PM, Pawel Salek <[email protected]> wrote:
> On 01/05/2011 07:38:31 PM, pancake wrote: >> I have written a patch for balsa-git. >> This patch fixes the following issues: >> *) if balsa is compiled without SSL support, it gets hanged when trying to >> connect to an SSL account >> - it fallbacks to non-SSL which is conceptually wrong because port may >> change if not in tls mode. >> - with this patch it just dont loads the account > > Is there some simple step-by-step reproduction scenario for this? Yup. 1) configure an ssl imap account with balsa+ssl 2) open balsa without ssl support and click on two different folders 3) crash glibc was reporting a free on invalid pointer. This is fixed by changing the boolean return value (see patch) > >> *) fixes a memory corruption issue that was making balsa crash when >> connecting to a server fails. > > Approved! > >> *) Fix autogen.sh (needs mkdir m4 and create an empty file) > > There is a better way to do it - see bootstrap.sh > Oops. My fault then >> *) The second patch fixes a packing issue in the account configuration >> wizard. > > Approved! > > Isnt all this wizard stuff correct for the last gnome guidelines? It looks strange to me. _______________________________________________ balsa-list mailing list [email protected] http://mail.gnome.org/mailman/listinfo/balsa-list
