Hi Jack: Am 07.01.18 20:33 schrieb(en) Jack:
Thanks! A stupid bug, not sending the “finalise” notification to the dialogue if opening the connection fails. Trivial patch is attached…Unfortunately, it doesn't seem to work. (Identical results with autotools and meson builds). I changed one of the yahoo servers to TLS, wait for the timeout, get the popup error, "Check" button re-enabled, but progress dialog remains showing with that one server.
This is strange… I tried “inbound.att.net” as server with bogus account information (user and password “test”). When using TLS (i.e. port 110 with STLS), no connection can be established, and the connection times out with a socket timeout error. When using POP3S, the connection can be established, but the login times out after one minute (debug output w/ the proposed log patch): 2018-01-08T17:38:46.296728Z balsa:14fa000 DEBUG[libnetclient]: connected to inbound.att.net 2018-01-08T17:38:46.697019Z balsa:14fa000 DEBUG[libnetclient]: connection is encrypted 2018-01-08T17:38:46.697095Z balsa:14fa000 DEBUG[libnetclient]: R '+OK Hello from jpop-0.1' 2018-01-08T17:38:46.697111Z balsa:14fa000 DEBUG[libnetclient]: W 'CAPA' 2018-01-08T17:38:46.807531Z balsa:14fa000 DEBUG[libnetclient]: R '+OK CAPA list follows' 2018-01-08T17:38:46.807558Z balsa:14fa000 DEBUG[libnetclient]: R 'IMPLEMENTATION jpop-0.1' 2018-01-08T17:38:46.807566Z balsa:14fa000 DEBUG[libnetclient]: R 'EXPIRE-NEVER' 2018-01-08T17:38:46.807572Z balsa:14fa000 DEBUG[libnetclient]: R 'PIPELINING' 2018-01-08T17:38:46.807578Z balsa:14fa000 DEBUG[libnetclient]: R 'RESP-CODES' 2018-01-08T17:38:46.807596Z balsa:14fa000 DEBUG[libnetclient]: R 'TOP' 2018-01-08T17:38:46.807602Z balsa:14fa000 DEBUG[libnetclient]: R 'UIDL' 2018-01-08T17:38:46.807614Z balsa:14fa000 DEBUG[libnetclient]: R 'USER' 2018-01-08T17:38:46.807622Z balsa:14fa000 DEBUG[libnetclient]: R 'SASL PLAIN XOAUTH2' 2018-01-08T17:38:46.807633Z balsa:14fa000 DEBUG[libnetclient]: R '.' 2018-01-08T17:38:46.807640Z balsa:14fa000 DEBUG[libnetclient]: emit 'auth' signal for client 0x1485cf0 2018-01-08T17:38:46.807667Z balsa:14fa000 DEBUG[libnetclient]: W 'AUTH PLAIN' 2018-01-08T17:38:46.920495Z balsa:14fa000 DEBUG[libnetclient]: R '+ ' 2018-01-08T17:38:46.920528Z balsa:14fa000 DEBUG[libnetclient]: W 'dGVzdAB0ZXN0AHRlc3Q=' 2018-01-08T17:39:46.975200Z balsa:14fa000 DEBUG[libnetclient]: W 'QUIT' 2018-01-08T17:39:47.058844Z balsa:14fa000 DEBUG[libnetclient]: R '-ERR [SYS/TEMP] Server error - Please try again later.' 2018-01-08T17:39:47.059066Z balsa:14fa000 DEBUG[libnetclient]: finalised connection to inbound.att.net But in *both* cases the progress dialogue is properly finalised after the timeout! There is no other code path where the dialogue is triggered. Are you sure you re-built everything after applying the patch? It basically boils down to shifting the finalise notification out of the “if (pop != NULL)” scope (around line 692 in libbalsa/mailbox_pop3.c), so it's really trivial. Cheers, Albrecht.
pgpLgy2tQxBrH.pgp
Description: PGP signature
_______________________________________________ balsa-list mailing list [email protected] https://mail.gnome.org/mailman/listinfo/balsa-list
