Review: Needs Fixing code review, no test account_statement_base_completion/statement.py, AccountStatementProfil._find_values_from_rules
* the docstring does not match the arguments of the method (no st_line, and calls and line are not described) * the "if not calls branch" will crash, it uses 'id' which is a Python built in function, not shadowed by a local variable here account_statement_base_completion/statement.py, AccountStatementCompletionRule.get_from_label_and_partner_name: * security rule bypass still there AFAICT I've pushed a few changes and improvements, don't forget to pull before fixing the points above) -- https://code.launchpad.net/~camptocamp-reviewer/banking-addons/fix-type-and-account-in-bk-st-line/+merge/160591 Your team Banking Addons Team is subscribed to branch lp:banking-addons/bank-statement-reconcile-70. -- Mailing list: https://launchpad.net/~banking-addons-team Post to : [email protected] Unsubscribe : https://launchpad.net/~banking-addons-team More help : https://help.launchpad.net/ListHelp
