Review: Needs Information code review and test
Hi Stefan,
I noticed base_iban makes the bank_bic field required in addition to the
in-code constraint (see base_iban/base_iban_data.xml)
<record id="bank_swift_field" model="res.partner.bank.type.field">
<field name="name">bank_bic</field>
<field name="bank_type_id" ref="bank_iban"/>
<field eval="True" name="required"/>
<field eval="False" name="readonly"/>
</record>
I believe this should be reverted by your module too, otherwise the bank
account creation wizard still requires the BIC.
--
https://code.launchpad.net/~therp-nl/banking-addons/ba70-bic_not_required/+merge/176704
Your team Banking Addons Core Editors is requested to review the proposed merge
of lp:~therp-nl/banking-addons/ba70-bic_not_required into
lp:banking-addons/banking-addons-70.
--
Mailing list: https://launchpad.net/~banking-addons-team
Post to : [email protected]
Unsubscribe : https://launchpad.net/~banking-addons-team
More help : https://help.launchpad.net/ListHelp
