In manifest, author should be ACSONE SA/NV. I also reach the conclusion that AccountStatementLine can be moved from account_statement_base_import to account_statement_base_completion, but this should be confirmed by someone more familiar with the project.
On a related note, the dependency of account_statement_base_import depends on account_statement_ext is redundant as it is pulled indirectly through account_statement_base_completion. In the _insert_line fix, I suggest renaming _get_values to something a bit more explicit such as _serialize_sparse_fields, and possiblity working on a copy of statement_store to avoid side-effects. Otherwise LGTM. -- https://code.launchpad.net/~acsone-openerp/banking-addons/bank-statement-reconcile-70/+merge/185047 Your team Banking Addons Core Editors is requested to review the proposed merge of lp:~acsone-openerp/banking-addons/bank-statement-reconcile-70 into lp:banking-addons/bank-statement-reconcile-7.0. -- Mailing list: https://launchpad.net/~banking-addons-team Post to : [email protected] Unsubscribe : https://launchpad.net/~banking-addons-team More help : https://help.launchpad.net/ListHelp
