Thanks for the review. I'll commit a change for #4 shortly (context passing), but I'm a bit puzzled by other points.
1. By auto_install, you mean explicitly setting it to False, right? I didn't know it was considered good practice. 2. Why do you think one line is preferable to three? Readability? 3. I don't understand why 'state' should be read-only. Isn't this attribute relevant only in views? There's no view for that model. -- https://code.launchpad.net/~savoirfairelinux-openerp/banking-addons/loose-coupling/+merge/185033 Your team Banking Addons Core Editors is requested to review the proposed merge of lp:~savoirfairelinux-openerp/banking-addons/loose-coupling into lp:banking-addons/bank-statement-reconcile-7.0. -- Mailing list: https://launchpad.net/~banking-addons-team Post to : [email protected] Unsubscribe : https://launchpad.net/~banking-addons-team More help : https://help.launchpad.net/ListHelp
