Review: Needs Information Agreed with Holger. Remain my concerns about the remote account (again I ask you, do you not retrieve this from the bank statement lines?) and the tag 86. I now do see some evidence for parsing structured tags 86 from line 295 on, but it seems to rely on the keys (REMI, ISTD) occuring always and always in the same order. Is this practical? If you are not entirely sure, I would recommend that you take a look at how the abnamro parse deals with these strings.
-- https://code.launchpad.net/~ruchir.shukla/banking-addons/account_banking_nl_mt940structured/+merge/172233 Your team Banking Addons Core Editors is subscribed to branch lp:banking-addons/6.1. -- Mailing list: https://launchpad.net/~banking-addons-team Post to : [email protected] Unsubscribe : https://launchpad.net/~banking-addons-team More help : https://help.launchpad.net/ListHelp
