Review: Needs Fixing code review, no tests Hi,
Thanks for the contribs ! My opinion on that one is that I prefer letting this method "def statement_import" as it is. His purpose is to import one single statement. Why not simply adding a new method called "def multi_statement_import" that call the first one for each instance ? This way, you reduce the risk of breaking others work by returning a dict instead of a int/long. For this reason, I mark it as need fixing. Regards, Joël -- https://code.launchpad.net/~akretion-team/banking-addons/bank-statement-reconcile-70-multi-statement/+merge/197761 Your team Banking Addons Core Editors is subscribed to branch lp:banking-addons/bank-statement-reconcile-7.0. -- Mailing list: https://launchpad.net/~banking-addons-team Post to : [email protected] Unsubscribe : https://launchpad.net/~banking-addons-team More help : https://help.launchpad.net/ListHelp
