Review: Needs Fixing code review Some things catched on a first sight:
- Use from . import xxx on __init__.py - 'if len(ids):' could be 'if ids', or better, put 'if not ids:' and put the rest of the code inside, returning only the value at the end, because it makes it more readable. - Don't use SQL query. You can use also ORM search with like operator. - Complete tests with calls to this method with more cases: account number without spaces that must be right, account number that must be wrong, so that we can test false positives. Regards. -- https://code.launchpad.net/~acsone-openerp/banking-addons/bank-statement-reconcile-70-improve-acc-number-completion/+merge/202861 Your team Banking Addons Core Editors is subscribed to branch lp:banking-addons/bank-statement-reconcile-7.0. -- Mailing list: https://launchpad.net/~banking-addons-team Post to : [email protected] Unsubscribe : https://launchpad.net/~banking-addons-team More help : https://help.launchpad.net/ListHelp
