On Wed, 2010-10-27 at 11:39 +0300, Vlad Dragu wrote: > I finished the implementation of OO code. > The newest version is uploaded to the repository
Congratz! And thanks a lot for undertaking this large code refactoring - I know it's not easy and not always a very rewarding task in itself, so kudos to you for this. Hopefully the code will be more pleasurable to work with, which is the nice part : ) > There's still some cleanup to be done, like removing from the > repository some files that are not used anymore or cleaning up some > big chunks of commented code from some files. Alright - if I get to review the code before Friday (which seems unlikely given the size of my todo-list right now), I'll keep it in mind. > Also, for some reason, the OWA code changes the default timezone > setting. This messes up the DateTime objects that i use instead of the > procedural php functions that php has (i found out the hard way about > this after approx 3hrs of debugging :) ) > The solution is to explicitly set the timezone in the scripts. I added > a constant to the config file for the time zone and set it to Central > European Time. I'm not sure if this is the way you would like it set > up, or do you want it on another timezone, a US timezone for example? Is it something that can be set in the config file? This way each installation can determine this depending on the sysadmin's taste ;p Personally I like to set it to UTC, since it's the closest we have to a "world clock", but since players will be spread across the world, there is no perfect answer imho. > I also worked a little on the tests, but i did not commit anything yet Good luck with those : ) Xavier. _______________________________________________ Farsides mailing list - [email protected] Wiki: http://farsides.com/ List: http://farsides.com/ml/ Forum: http://farsides.com/forum/ Ideas: http://farsides.com/ideas/ Chat: http://farsides.com/chat/
