On 12/13/2010 5:22 PM, Xavier Antoviaque wrote:
Hi Vlad,
I've had a look at your commit history, and found a few issues that
prevented me from merging it to the trunk:
http://bazaar.launchpad.net/~vlad-dragu/hackit/alpha2.0/revision/151 :
This would remove the "versioning" table, which was apparently missing
from your database when you ran the 'make release'.
[vlad] i didn't manually touched the versioning table so i'm not exactly
sure how it got wiped out.
Could a command from the make file result in that table being erased?
Maybe a make upgrade that worked with a db schema that didn't have that
table?
I'll add the table in my db. I'll look for its schema from an older commit
http://bazaar.launchpad.net/~vlad-dragu/hackit/alpha2.0/revision/152 :
Why do you remove the "error_reporting(E_ALL& ~E_DEPRECATED);"? I've
added it on purpose, to make sure we all run tests with the same error
reporting configuration - did it create issues?
[vlad] from my experience, sometimes setting environment vars at runtime
can have unexpected results.
That's why i choose to remove it from there and rely only on the ini
files and try to replicate the warnings you get.
Unfortunately i wasn't successful :(
I think it's safest to add that line of code after we figure the
differences out.
http://bazaar.launchpad.net/~vlad-dragu/hackit/alpha2.0/revision/153 :
This one is probably just me, but I couldn't understand why this would
fix the bughttps://bugs.launchpad.net/hackit/+bug/676908 . I've updated
the bug to keep the discussion in one place - let me know!
[vlad] I explained my reasoning on the bug page
_______________________________________________
Farsides mailing list - [email protected]
Wiki: http://farsides.com/
List: http://farsides.com/ml/
Forum: http://farsides.com/forum/
Ideas: http://farsides.com/ideas/
Chat: http://farsides.com/chat/
