Hi, I went through the code for the last two iterations, to get you some comments Vlad. Note that not all of those points are things to fix immediately (see below for the acceptance status of the last iteration), some are just things to be careful about in the future.
[Admin reports] http://bazaar.launchpad.net/~vlad-dragu/hackit/jquery_windows/revision/187 * Missing comments in the code - it is almost not commented at all, which makes it harder for another developer to read the code, or even for you to come back to it later on * Will need to factorize header/include/footers of the admin pages, to avoid having to edit multiples pages if we have to make changes to those duplicated parts [jquery windows] http://bazaar.launchpad.net/~vlad-dragu/hackit/jquery_windows/revision/190 * All fine, didn't see any issue! http://bazaar.launchpad.net/~vlad-dragu/hackit/jquery_windows/revision/191 * Same issue with comments in hackit.js as above - when there are comments around the code you add you usually add comments, but when it's a new section of code or when you're modifying a section of code without comments, you seem to forget about it : ) So, it leaves only the issue of documentation to release the payment. Btw, I've updated the bugtracker, cleaned the bugs and added new milestones: https://launchpad.net/hackit/+milestone/alpha3.1 (last iteration) https://launchpad.net/hackit/+milestone/alpha4.0 (next stable release, for the street demo at the end of next month) Xavier.
_______________________________________________ Farsides mailing list - [email protected] Wiki: http://farsides.com/ List: http://farsides.com/ml/ Forum: http://farsides.com/forum/ Ideas: http://farsides.com/ideas/ Chat: http://farsides.com/chat/
