Hi, Here is the log of the chatroom at http://farsides.com/chat/ (or irc://irc.freenode.net/#farsides) for the 2011-11-06.
2011-11-06 07:35:36+0000 dachary (dachary) is now online 2011-11-06 08:02:25+0000 mtyaka (mtyaka) is now online 2011-11-06 08:33:51+0000 dachary (dachary) is now online 2011-11-06 10:09:07+0000 dachary (dachary) is now online 2011-11-06 10:48:32+0000 dachary (dachary) is now online 2011-11-06 11:52:43+0000 MCMic (MCMic) is now online 2011-11-06 12:56:36+0000 Lapin__ (Lapin__) is now online 2011-11-06 12:56:50+0000 Lapin_ (Lapin_) is now online 2011-11-06 18:39:48+0000 <mtyaka> hello 2011-11-06 18:40:04+0000 <mtyaka> antoviaque: here? 2011-11-06 18:43:55+0000 antoviaque (antoviaque) is now online 2011-11-06 18:53:19+0000 <dachary> antoviaque: wake up 2011-11-06 18:53:27+0000 <dachary> mtyaka: asks for you 2011-11-06 18:53:34+0000 <dachary> :-) 2011-11-06 18:53:38+0000 <antoviaque> what what? :) 2011-11-06 18:53:57+0000 <mtyaka> hi dachary, hi antoviaque :) 2011-11-06 18:53:58+0000 <antoviaque> I missed something again, right? :) 2011-11-06 18:54:03+0000 <antoviaque> hello :) 2011-11-06 18:54:05+0000 <dachary> ahahah 2011-11-06 18:54:58+0000 <antoviaque> (seriously, I crashed, so if there is something I should look at please copy&paste :) ) 2011-11-06 18:55:33+0000 <mtyaka> i wanted to ask you something... looking for it, just a moment 2011-11-06 18:56:13+0000 <mtyaka> ah, ok. issue #544 (countdown before vote and results phases) 2011-11-06 18:56:46+0000 <mtyaka> I was thinking about this task... We want for every game to end eventually, even if the GM abandons it, right? 2011-11-06 18:57:13+0000 <mtyaka> Which means the countdown needs to be done on the server 2011-11-06 18:57:46+0000 <mtyaka> Does that sound right? 2011-11-06 18:58:22+0000 <mtyaka> antoviaque: ^ 2011-11-06 18:58:42+0000 * antoviaque looking 2011-11-06 18:58:58+0000 <antoviaque> mtyaka: yep, exactly 2011-11-06 18:59:12+0000 <antoviaque> it's actually mostly meant for when the GM quits 2011-11-06 18:59:28+0000 <antoviaque> Since new players start by creating a game, this happens quite often 2011-11-06 18:59:48+0000 <mtyaka> i see 2011-11-06 19:01:22+0000 <mtyaka> I will need to discuss it with dachary then 2011-11-06 19:01:42+0000 <mtyaka> dachary: If you've got a moment, can you take a look at http://tickets.farsides.com/issues/544 2011-11-06 19:02:35+0000 <mtyaka> I would like your advice on what the best way would be to implement this server-side... 2011-11-06 19:03:53+0000 <mtyaka> ... and if you think it's even feasible for a twisted noob like me to go an try to implement something like that 2011-11-06 19:04:10+0000 <mtyaka> antoviaque: in the meantime, I have another problem to bug you with... 2011-11-06 19:04:14+0000 <antoviaque> sure 2011-11-06 19:04:43+0000 <mtyaka> I finished #441, but I can't set it as "ready for review" 2011-11-06 19:04:52+0000 <mtyaka> I think it's because it's a "story" type of a task 2011-11-06 19:05:04+0000 <mtyaka> (which I only noticed after I already finished it) 2011-11-06 19:05:16+0000 * dachary taking a look 2011-11-06 19:05:19+0000 <mtyaka> (and spammed it with comments) 2011-11-06 19:05:49+0000 <antoviaque> Ah, yep - np, I'll switch it to a task and recreate a related story 2011-11-06 19:06:09+0000 <mtyaka> thanks a lot :) 2011-11-06 19:06:19+0000 <dachary> mtyaka: what would you like to discuss about #544 ? 2011-11-06 19:07:40+0000 * dachary going to fall from the face of the earth in 5 minutes 2011-11-06 19:07:51+0000 <mtyaka> dachary: The countdown would need to be done server-side. How hard do you think it would be to implement this? 2011-11-06 19:07:57+0000 <antoviaque> mtyaka: done - have a look to check, should be alright now : ) 2011-11-06 19:08:02+0000 <dachary> :-) 2011-11-06 19:08:09+0000 <dachary> hum 2011-11-06 19:08:26+0000 <mtyaka> thanks, antoviaque :) 2011-11-06 19:10:48+0000 <dachary> mtyaka: what about setting a field that records the time when the game is "ready" ? ready_to_vote and ready_to_complete fields 2011-11-06 19:11:10+0000 <dachary> they don't need to be stored in the database 2011-11-06 19:11:52+0000 <mtyaka> right... 2011-11-06 19:16:33+0000 <mtyaka> dachary: if it was javascript on the server, I'd probably just do a setTimeout, and if the game master decides to change the countdown interval, clear the previous timeout and set a new one. 2011-11-06 19:17:45+0000 <dachary> there are a number of issues to deal with if you go this route. The first of which being : what happens if the user is not connected when the timeout happens and (s)he is 5 seconds late ? 2011-11-06 19:18:49+0000 <dachary> if the specs were : "automatically go to the next phase if the gm timesout" your approach would make sense. 2011-11-06 19:19:39+0000 <mtyaka> hmm... that's actually how i read the specs :) 2011-11-06 19:19:42+0000 <mtyaka> what did i miss? 2011-11-06 19:23:17+0000 <dachary> mtyaka: you did not miss anything. 2011-11-06 19:23:19+0000 <dachary> I did ;-) 2011-11-06 19:23:36+0000 <dachary> Then a timeout server side would be fine 2011-11-06 19:24:05+0000 <dachary> but 2011-11-06 19:24:19+0000 <dachary> I think to remember it already is implemented. 2011-11-06 19:24:43+0000 <mtyaka> oh, that'd be great 2011-11-06 19:25:50+0000 <dachary> the timeout is game-timeout 2011-11-06 19:26:02+0000 <dachary> which is set by default to 1 day 2011-11-06 19:26:22+0000 <dachary> after one day the game goes to the next state if nothing happened *and* it is ready 2011-11-06 19:26:36+0000 <dachary> I suppose that's why I misunderstood the specs ;-) 2011-11-06 19:28:11+0000 <mtyaka> I see, that's excellent :) 2011-11-06 19:28:44+0000 <dachary> yes, it's delightfull when the work is done already ;-) 2011-11-06 19:29:43+0000 <mtyaka> But it seems it doesn't work properly? 2011-11-06 19:30:01+0000 <dachary> really ? why ? 2011-11-06 19:30:49+0000 <mtyaka> Some games in my "list of games" are weeks old already and still stuck in the "pick" state 2011-11-06 19:31:00+0000 <mtyaka> This one for example: http://cardstories.org/?game_id=838 2011-11-06 19:32:24+0000 <dachary> IIRC antoviaque asked for game-timeout to be set to 1 month 2011-11-06 19:32:30+0000 <dachary> let me check 2011-11-06 19:32:43+0000 <mtyaka> heh, ok, that would explain it :) 2011-11-06 19:32:59+0000 <antoviaque> dachary: timeout currently moves forward the game or deletes it? 2011-11-06 19:33:14+0000 <dachary> antoviaque: it moves forward the game if it can 2011-11-06 19:33:18+0000 <antoviaque> ohhh 2011-11-06 19:33:31+0000 <antoviaque> what if it can't? 2011-11-06 19:33:49+0000 <dachary> it cancels it 2011-11-06 19:35:44+0000 <antoviaque> the timeout starts as soon as it enters a new state, too, right? (here it would be when the game *can* be moved the the next phase) 2011-11-06 19:36:22+0000 <antoviaque> but good to know that it allows to move it forward, I thought this feature was merely to delete old unfinished games 2011-11-06 19:38:12+0000 <mtyaka> if I understand the code correctly, you're right, the timeout starts when it enters a new state 2011-11-06 19:40:30+0000 <mtyaka> antoviaque: The ticket doesn't explicitly state it, but the countdown is supposed to be visible to the players (and author), is that right? 2011-11-06 19:40:57+0000 <antoviaque> yep,so that players know how much more time they would have to wait at most 2011-11-06 19:42:43+0000 <mtyaka> ok, in order to show the remaining time, we'd need to set a field with the time, as dachary initially suggested 2011-11-06 19:53:05+0000 <mtyaka> so the timeout currently implemented serves a slightly different purpose - it deletes games that were stuck because they couldn't be moved to the next phase. 2011-11-06 19:53:37+0000 <mtyaka> The new timeout from #544 would only kick in once the game is in a state where it can go to the next phase 2011-11-06 19:56:08+0000 <mtyaka> If the first timeout is set to one month, I'm not sure it actually serves it's purpose, though - we probably restart the server more than once a month. The timeouts don't survive server restarts. 2011-11-06 19:57:12+0000 <mtyaka> Perhaps it would be better to delete stuck games that couldn't go to the next phase during server startup. 2011-11-06 20:01:09+0000 <antoviaque> mtyaka: the reason I set this timeout to such a large number is that cancelled games didn't had a view, and were giving an error popup 2011-11-06 20:01:24+0000 <antoviaque> which was confusing to players who were coming back to a game to see if it had moved forward 2011-11-06 20:02:24+0000 <antoviaque> we could setup this timeout to a lower value (maybe once a week?), but then we'll also need to take care of having a proper view & message for people who visit cancelled games 2011-11-06 20:03:11+0000 <antoviaque> it was a long time ago so my memory is fuzy, but I think I remember we didn't do that the first time because creating views for cancelled games was tricky - but could be good to confirm with dachary, not sure 2011-11-06 20:03:14+0000 <antoviaque> mtyaka: ^ 2011-11-06 20:03:54+0000 <mtyaka> I see, thanks for clarifying. 2011-11-06 20:04:41+0000 <mtyaka> It seems like special views for cancelled games shouldn't be hard to implement (but it is likely that I am missing something) 2011-11-06 20:05:35+0000 <mtyaka> But either way, cancelled games are a different problem than the one #544 is trying to solve 2011-11-06 20:06:07+0000 <antoviaque> yep 2011-11-06 20:06:20+0000 <antoviaque> both have their place, but serve different purposes 2011-11-06 20:06:38+0000 <mtyaka> Yup, I understand now. 2011-11-06 20:09:57+0000 <mtyaka> The good news is that the new timeout for #544 shouldn't be too much different implementation-wise from the old game-cancelling timeout, which gives me some confidence that I can do it myself :) 2011-11-06 20:10:54+0000 <mtyaka> So I'll try to do it and then let dachary rip it apart when he reviews the code, hehe :) 2011-11-06 20:12:07+0000 <antoviaque> mtyaka: hehe, good luck :p 2011-11-06 20:32:39+0000 dachary (dachary) is now online 2011-11-06 22:38:30+0000 dachary1 (dachary1) is now online _______________________________________________ Farsides mailing list - [email protected] Wiki: http://farsides.com/ List: http://farsides.com/ml/ Forum: http://farsides.com/forum/ Ideas: http://farsides.com/ideas/ Chat: http://farsides.com/chat/
