On Thu, 2010-09-02 at 20:06 +0200, Xavier Antoviaque wrote: > > Today I modified the UPDATE file, I created the sql file to update > the > > db structure from alpha 1.1 to alpha 1.2 and created a sql folder to > > hold all sqls
Looks good! > > I modified the release notes, I generated the change log. Because > > the change log was too big I kept it in a separate file and > > referenced it in the release notes. Perfect! Good job on the Release notes, it looks really good. The changelog is fine too - for this release, I'll ignore the requirement to describe the changes on the file level. Just keep it in mind for the next release, while you commit. If you commit frequently enough, you'll meet this requirement when you generate the Changelog. David, there is one bug that is still open in "Incomplete" status - can you check if they must be put as "Fix released" ? https://bugs.launchpad.net/hackit/+bug/622232 And there is also the OWA issue that Vlad is working on - the release of funds is only pending that part now, right? https://bugs.launchpad.net/hackit/+bug/601603 For the code review: * 2 small fixes - cf trunk repository log http://bazaar.launchpad.net/~hackit/hackit/trunk/changes * Also, the latest changes feature wasn't implemented in OO - not going to block the release for it, but remember for the next release that this kind of addition need to meet the OO requirement. Thx! I've also merged, commited & pushed the latest revision from Vlad to trunk. For the return character issue in some files - there is a plugin might help you solve this: http://doc.bazaar.canonical.com/plugins/en/checkeol-plugin.html Xavier. _______________________________________________ Hackit Bar mailing list - [email protected] Wiki: http://community.hackit.cx/ List: http://community.hackit.cx/ml/ Forum: http://community.hackit.cx/forum/ Ideas: http://community.hackit.cx/ideas/ IRC: irc://irc.freenode.net/#politis
