I've started to test the mission. It seems to work well from what I see !
I've got a first set of questions that will help me testing further. I also
include a first review template at the end of the mail.
In the mission test :
* why does the content of the chat disappear when I do something wrong
? (Ex : click on any button except 'reply' at the beginning of the chat,
then I don't see the content of mission-start2-other, I see nothing). Then
I'm unable to return to the chat, except if I clear mission data.
[Vlad] the test file cannot replicate very exactly the frontend environment
wich is based on ajax calls. The fact that nothinge is displayed on the
screen in the test file, signifies that the mission engine did not return
any message. In the live game this will mean that nothing will change from
the perspective of the player, so the previous message will still be there
for the player to see
* second step of the chat : the text ends with 'redirected the user
to' and then I need to click on 'ok resirected to site' : this step is
something that will be triggered by an action of the player or is it
automatic ?
[Vlad] this will be automatic in the live game. The player will be
redirected, so the page will reload and this will re-instantiate the mission
class and it will automatically go to the next step.
* should I already try simpletest and JScoverage and windmill for that
iteration ?
[Vlad] only the php unit tests (simpletest) can be tested at this point. The
others can be tested only after the frontend part of the missions is
complete
* Do you see any other test I could perform to test your backend ?
[Vlad] you can check the way the exceptions are handled. Basically, you push
another button than the correct one J . when doing this, you should not
consider a blank screen as a sign that something went wront. Rather you
should consider that nothing happened on the screen. So for example, if the
system waits for you to hit reply and you hit something else, the screen
will go blank. But the system is still waitng for you to hit reply. If you
do you the mission will go to the next step.
Also, you can check the php unit tests.
thx
D
Step
Description
Status
Comment
1
Merge developer branch (bzr merge lp:xxx)
OK
2
Follow update procedure (described in UPDATE file)
NOK
Update file is still from the 1.2. I'm not sure about te command also.
3
Tests: simpletest & JSCoverage at 100% and without error for all new code
(+check that new files are taken into account)
NOK
should I run them for the missions ?
4
Tests: Windmill tests run without error (run all & verify created for new
features)
NOK
should I run them for the missions ?
5
QA: Test release changes (compare with specs)
OK
pending on a few points
6
QA: Browser compatibility (IE 6-7-8, Firefox 2-3, Safari, Chrome, Opera)
OK
apart from the bug related to IE6
7
Code review: Read code <https://code.launchpad.net/hackit> for each change
& comment
NOK
pending
8
Code review: Check other deliverable
<http://community.hackit.cx/wiki/Requirements_and_deliverables_for_patch_sub
mission> requirements (documentation, OO, commit isolation...)
NOK
pending
9
<https://bugs.launchpad.net/hackit> Bugtracker: Check fixed bugs (open bugs
for this release must all be in Confirmed state at the end)
NOK
612470, 611815, 605623, 601603
10
Check & publish release notes
<http://community.hackit.cx/wiki/Requirements_and_deliverables_for_patch_sub
mission#Release_notes>
NOK
I did not find a release note for the 2.0
11
Commit & push
NOK
_______________________________________________
Hackit Bar mailing list - [email protected]
Wiki: http://community.hackit.cx/
List: http://community.hackit.cx/ml/
Forum: http://community.hackit.cx/forum/
Ideas: http://community.hackit.cx/ideas/
IRC: irc://irc.freenode.net/#politis
