[PATCH v2 14/19] ARM: i.MX53: boot: Move magic numbers info utility functions

[Andrey Smirnov]

Signed-off-by: Andrey Smirnov <andrew.smir...@gmail.com>
---
 arch/arm/mach-imx/boot.c | 21 +++++++++++++++------
 1 file changed, 15 insertions(+), 6 deletions(-)

diff --git a/arch/arm/mach-imx/boot.c b/arch/arm/mach-imx/boot.c
index f84be5c68..799d5ec93 100644
--- a/arch/arm/mach-imx/boot.c
+++ b/arch/arm/mach-imx/boot.c
@@ -171,10 +171,12 @@ void imx51_get_boot_source(enum bootsource *src, int 
*instance)
 
 #define IMX53_SRC_SBMR 0x4
 #define SRC_SBMR_BMOD  GENMASK(25, 24)
+#define IMX53_BMOD_SERIAL      0b11
 
 #define __BOOT_CFG(n, m, l)    GENMASK((m) + ((n) - 1) * 8, \
                                        (l) + ((n) - 1) * 8)
 #define BOOT_CFG1(m, l)                __BOOT_CFG(1, m, l)
+#define BOOT_CFG3(m, l)                __BOOT_CFG(3, m, l)
 
 #define ___BOOT_CFG(n, i)      __BOOT_CFG(n, i, i)
 #define __MAKE_BOOT_CFG_BITS(idx)                                      \
@@ -204,17 +206,27 @@ static int imx53_bootsource_internal(uint32_t r)
        return FIELD_GET(BOOT_CFG1(7, 4), r);
 }
 
+static int imx53_port_select(uint32_t r)
+{
+       return FIELD_GET(BOOT_CFG3(5, 4), r);
+}
+
 static bool imx53_bootsource_nand(uint32_t r)
 {
        return FIELD_GET(BOOT_CFG1_7, r);
 }
 
+static enum bootsource imx53_bootsource_serial_rom(uint32_t r)
+{
+       return BOOT_CFG1(r, 3) ? BOOTSOURCE_SPI : BOOTSOURCE_I2C;
+}
+
 void imx53_get_boot_source(enum bootsource *src, int *instance)
 {
        void __iomem *src_base = IOMEM(MX53_SRC_BASE_ADDR);
        uint32_t cfg1 = readl(src_base + IMX53_SRC_SBMR);
 
-       if (imx53_get_bmod(cfg1) == 0x3) {
+       if (imx53_get_bmod(cfg1) == IMX53_BMOD_SERIAL) {
                *src = BOOTSOURCE_USB;
                *instance = 0;
                return;
@@ -225,10 +237,7 @@ void imx53_get_boot_source(enum bootsource *src, int 
*instance)
                *src = BOOTSOURCE_HD;
                break;
        case 3:
-               if (cfg1 & (1 << 3))
-                       *src = BOOTSOURCE_SPI;
-               else
-                       *src = BOOTSOURCE_I2C;
+               *src = imx53_bootsource_serial_rom(cfg1);
                break;
        case 4:
        case 5:
@@ -246,7 +255,7 @@ void imx53_get_boot_source(enum bootsource *src, int 
*instance)
        case BOOTSOURCE_MMC:
        case BOOTSOURCE_SPI:
        case BOOTSOURCE_I2C:
-               *instance = (cfg1 >> 20) & 0x3;
+               *instance = imx53_port_select(cfg1);
                break;
        default:
                *instance = 0;
-- 
2.14.3


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox