On Thu, Mar 19, 2009 at 07:43:43PM +0100, Nicolas wrote: > Hi, > > Have you found time to debug the photo feature ?
Found it. Took me a while, though. :-) First, I had to get past some evolution-data-server library hurdles. It looks like you didn't run into this, but I posted a patch over on the opensync-devel list that takes care of that. As for the photo crashing bug, it was a free() call on a non-malloc()'d variable. The code in vformat.c that generated the final VCARD BEGIN/END text data, altered the internal GList pointers to point to a static string like "BASE64" or "B". I fixed these with calls to g_strdup(). I also changed the default config format for Blackberry PIN numbers to hex, in the barry-sync XML config file. Barry reports PIN numbers in hex, and the Blackberry does too, so might as well keep it consistent. In my travels through the code, vformat.c had comments that stated that PHOTO fields in VCARD's need to have TYPE parameters as well. I don't know what those values are in the RFC, but it occurs to me that we may need to do some conversion. Do you know what photo image format the Blackberry uses? I haven't had time to look tonight. Your Photo patch should apply to the top of the latest master branch. I'd like to have the TYPE and photo format issues nailed down first before I apply it. Can you look into this? Thanks! - Chris ------------------------------------------------------------------------------ _______________________________________________ Barry-devel mailing list Barry-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/barry-devel
