On Thu, Apr 09, 2009 at 08:49:09PM +0800, Ryan Li wrote:
> I've fixed the parser and I think it's now OK.

Applied, with some changes.  Thanks!

I removed the #defines that were governing the indexes into the metadata
and just replaced all that with a metadata struct in protostructs.h.
I also fixed some endian bugs, and a null terminator bug that I didn't
notice until I piped the output through less. :-)


> Right, it's endian issue, since the message encoded in UCS-2 is in big 
> endian, but iconv takes little endian as default. As you suggested, I 
> tried desperately to add a BOM, but didn't work. Several hours later I 
> realized a more directly "UCS-2BE" should work instead of "UCS-2". And 
> it did. No preprocess anymore. :-)

Fantastic, thanks. :-)



> I see it and made it this time. But I want to know how to change the 
> GIT_COMMITER_IDENT and GIT_AUTHOR_IDENT variables? They look pretty 
> ugly, not displaying my email correctly. Anyway, attached the patch file.

I fixed the commit header for you.  You can change your email settings
with:

        git config --global user.name "Ryan Li"
        git config --global user.email "r...@ryanium.com"

This sets up your ~/.gitconfig file so that all your git work will have
this set automatically.

- Chris


------------------------------------------------------------------------------
This SF.net email is sponsored by:
High Quality Requirements in a Collaborative Environment.
Download a free trial of Rational Requirements Composer Now!
http://p.sf.net/sfu/www-ibm-com
_______________________________________________
Barry-devel mailing list
Barry-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/barry-devel

Reply via email to