On Fri, May 01, 2009 at 08:46:08PM +0200, Nicolas wrote:
> Hi,
>
> I have just added the Memo sync support.
Applied, with minor changes, and an update to btool. Thanks very much!
Can you retest on your side to make sure that my change to r_memo.cc's
builder function is ok on the Storm? I added the MEMO_TYPE field, set to
'm', since that's how we get the data from the device.
My only worry is this code:
+ string title = GetAttr("SUMMARY", "/vjournal");
+ trace.logf("SUMMARY attr retrieved: %s", title.c_str());
+ if( title.size() == 0 ) {
+ title = "<blank subject>";
+ trace.logf("ERROR: bad data, blank SUMMARY: %s", vjournal);
+ }
What happens if, for example, Evolution has a blank memo title, we add
a "blank subject" line to it, and then you sync again? Won't that duplicate
the record on the following sync?
- Chris
------------------------------------------------------------------------------
Register Now & Save for Velocity, the Web Performance & Operations
Conference from O'Reilly Media. Velocity features a full day of
expert-led, hands-on workshops and two days of sessions from industry
leaders in dedicated Performance & Operations tracks. Use code vel09scf
and Save an extra 15% before 5/3. http://p.sf.net/sfu/velocityconf
_______________________________________________
Barry-devel mailing list
Barry-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/barry-devel
