Thanks for your comments. This is 'preliminary' support intended to get
something working so I could use it - I had intended to improve on it :)
Some responses:
On Sat, 2009-05-09 at 03:12 -0400, Chris Frey wrote:
> > It also fixes up a problem with some addresses not syncing and a
> > case-issue in Evo.
>
> I noticed that the patch includes changes like this:
>
>
> > // add all applicable phone numbers... there can be multiple
> > // TEL fields, even with the same TYPE value... therefore, the
> > // second TEL field with a TYPE=work, will be stored in WorkPhone2
> > - AddPhoneCond("pref", con.Phone);
> > - AddPhoneCond("fax", con.Fax);
> > - AddPhoneCond("work", con.WorkPhone);
> > - AddPhoneCond("work", con.WorkPhone2);
> > - AddPhoneCond("home", con.HomePhone);
> > - AddPhoneCond("home", con.HomePhone2);
> > - AddPhoneCond("cell", con.MobilePhone);
> > - AddPhoneCond("pager", con.Pager);
> > + AddPhoneCond("PREF", con.Phone);
> > + AddPhoneCond("FAX", con.Fax);
> > + AddPhoneCond("WORK", con.WorkPhone);
> > + AddPhoneCond("WORK", con.WorkPhone2);
> > + AddPhoneCond("HOME", con.HomePhone);
> > + AddPhoneCond("HOME", con.HomePhone2);
> > + AddPhoneCond("CELL", con.MobilePhone);
> > + AddPhoneCond("PAGER", con.Pager);
> > AddPhoneCond(con.OtherPhone);
>
> This was for a bug in SynCE, as I recall.
> http://www.mail-archive.com/barry-devel@lists.sourceforge.net/msg01109.html
> I don't recall that Evolution had this problem.
>
This seems to be a problem in OpenSync, not SynCE (possibly Opensync
0.3x - I have seen other unrelated 'quirks' that are clearly Opensync
problems). SynCE is not part of my 'berry sync chain anywhere. I found
that the lowercase values led to data failing to be transferred to Evo
(v2.24.1.1). I agree that this is most likely to be an Opensync rather
than a Barry problem though.
>
> > +unsigned short vCalendar::GetMonthWeekNumFromBYDAY(const std::string&
> > ByDay)
> > +{
> > + return atoi(ByDay.substr(0,ByDay.length()-2).c_str());
> > +}
>
> I'm confused by this... BYDAY can contain strings like this, according
> to the RFC:
>
> BYDAY=MO,TU,WE,TH,FR
>
> Which doesn't work with an atoi() call.
True. However, Evo/Opensync seems to spit out a single (-)xDD BYDAY
value, (e.g. -2SU being second Sunday from last) in the BYDAY line for
single recurrent BYMONTH events and I needed something to work. I intend
to improve on this.
>
> > case Calendar::Day: // eg. every day
> > - AddParam(attr, "FREQ", "DAILY");
> > + //AddParam(attr, "FREQ", "DAILY");
> > + AddValue(attr,"FREQ=DAILY");
> > break;
>
> Looks like I was hoping for better support in vformat.c... Thanks. :-)
> I need to do more testing on this, but your change looks better than
> my code on first glance.
This came about because the RRULE field was being incorrectly generated
as:
RRULE;FREQ=MONTHLY:BYDAY=-3
and it should be
RRULE:FREQ=MONTHLY;BYMONTHDAY=-3
>
>
> > + // we do have COUNT. This means we won't have UNTIL. So
> > we need to
> > + // process the RecurringEndTime from the current start
> > date. Set the count level to
> > + // something other than zero to indicate we need to
> > process it as the exact end date will
> > + // depend upon the frequency.
> > + count=atoi(args["COUNT"].c_str());
> > + }
> > + }
>
> I added a check here so that an exception would be thrown if count == 0.
> This seems to match the RFC requirements too, and makes your if(count)
> tests below safer.
Agreed.
I have almost completed two-way task syncing support in the 0.4x plugin.
Expect another patch very shortly :)
John.
------------------------------------------------------------------------------
The NEW KODAK i700 Series Scanners deliver under ANY circumstances! Your
production scanning environment may not be a perfect world - but thanks to
Kodak, there's a perfect scanner to get the job done! With the NEW KODAK i700
Series Scanner you'll get full speed at 300 dpi even with all image
processing features enabled. http://p.sf.net/sfu/kodak-com
_______________________________________________
Barry-devel mailing list
Barry-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/barry-devel
