On Tue, Jun 23, 2009 at 05:09:06PM +0200, Nicolas wrote: > Hi, > > In attachment a first patch to use JVM debugger.
Thanks Nicolas! Some great work there. Lots of code for me to read over. I haven't read it in super detail yet. > Chris, my patch don't touch the rest of barry code. But I think that > it's better to put bjavadebug compilation optionnal. > (--enable-javadebug) That's true... it doesn't look like the code touches too much of the rest of Barry. I don't think it is necessary to make this compile time dependent though. It's just one more command, like btool, or bjavaloader. I'm inclined to accept the code as is. I did notice that under doc/javadebug there are jar/ and src/ directories, with HelloWorld sample binaries and sample source, and the copyright is from RIM. Obviously, I can't accept any code like that. :-) If you could respin your patch, and replace those directories with a document explaining how to get those files ourselves, including URLs or the steps needed to get it, that would be acceptable. Thanks, - Chris ------------------------------------------------------------------------------ _______________________________________________ Barry-devel mailing list Barry-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/barry-devel
