On Sat, Jun 27, 2009 at 10:34:09PM +0800, Ryan Li wrote: > Hi, > > Here's a patch for Sms encoding conversion. > Until today have I found that 7-bit SMS uses another encoding other than > ASCII as I first thought. It's an encoding designed specially for GSM > SMS, enabling characters with accents, like '??', and some symbols. > As far as I am concerned, iconv provides no function to convert this > charset from/to others. Hence I wrote one myself, and added it to the > Sms class, since I don't think it'll be used elsewhere. An inverted > conversion function may be provided when the builder will be available. > Additional information can be found in the comments. > Along with the patch, there're some code cleanups.
Thanks Ryan! The patch looks good. I've applied it, except for some fixup-only changes that went against the coding guideline. In the future, if you change indenting or brackets, etc, please put them in their own patch, so it is easier to know what is an actual change vs. cleanup. Also, I don't have any SMS messages that use the 7bit GSM alphabet, so I can't fully test it. Anyone else able to test? > By the way, I've found that Net Direct's homepage has had a nice update. > However, many links in Barry's page are broken, e.g, > http://netdirect.ca/software/packages/barry/barry/install.php > should be > http://netdirect.ca/software/packages/barry/install.php > instead. Thanks. New server... I'll report it. :-) I don't think I have access to it just yet, but hopefully soon. - Chris ------------------------------------------------------------------------------ _______________________________________________ Barry-devel mailing list Barry-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/barry-devel
