On Mon, Oct 11, 2010 at 10:50:38AM +0100, Toby Gray wrote: > Sounds sensible to me. Thanks for reverting that change and I apologise > for not doing the logging change in a separate commit so that you had to > reapply it.
No worries... sometimes that happens... it's the first time I've had to really pick apart a patch like that. :-) Usually it's all forward motion, but these firmware issues are tricky. > The reason for having the m_seen_usb_error check in DoRead() is for when > the BlackBerry is physically unplugged. Without it the read thread > constantly tries to do a bulk read, receives a Usb::Error as it's > unplugged, notifies all the handlers and then immediately tries a > DoRead() again. This caused 100% CPU usage for a short while and, more > annoyingly, puts lots of output on stderr about and handler receiving > USB errors. Oops, I meant DefaultRead(). We still set seen_error in DoRead(), I've added the check back to DefaultRead(), which I think you said was needed for recovering from errors... possibly in Close? My memory is fuzzy on this. If you notice something that still needs repair, please send me a patch, or let me know. Thanks, - Chris ------------------------------------------------------------------------------ Beautiful is writing same markup. Internet Explorer 9 supports standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3. Spend less time writing and rewriting code and more time creating great experiences on the web. Be a part of the beta today. http://p.sf.net/sfu/beautyoftheweb _______________________________________________ Barry-devel mailing list Barry-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/barry-devel
