On Wed, Nov 09, 2011 at 05:13:42PM +0000, Toby Gray wrote: > On 08/11/11 22:57, Chris Frey wrote: > > If you can somehow adjust Android's build system to make sure that all > > system directories are listed first, and that all Barry headers must > > be included via <barry/...>, then this shouldn't be a problem. Is this > > possible? > > Yes, turns out it is possible. Thanks for the suggestion. I've fixed my > github branch at git://github.com/tobygray/barry.git to contain your > various suggestions and fixes.
Excellent! > 1) When running make from the top level, make will recurse into the > android directory. There are no default targets, but it's possibly a > little ugly that you see android mentioned in make output, even when not > building for it. Yeah, if we don't need to recurse into android, that would be best. > 2) When you do want to build for android you have to cd into > barry/android and run "make android-binaries". > > Can you think of a good way of being able to maintain a list of > EXTRA_DIST files, yet not have make recurse into an Android directory? > Or are you happy with it the way it currently is? I'm assuming that you need EXTRA_DIST for the buildtest script? Or do you need it for your own work? I just put the whole android directory into the top level EXTRA_DIST, with a few other tweaks, and it works for me here. I don't see that it is strictly necessary to have android/ in the subdirs list, so I removed that. Let me know if that was a mistake. I merged/cherry-picked in your android branch (I did a bit of work on it along the way, so it is out of order compared to yours, sorry) The libusb error code patch got me thinking, and I had to change it back, for the most part, but I also changed the API of the Init call that relied on it, so hopefully this issue is fully solved now. The TranslateErrcode() function is now just a convenience function, which it almost was before, and the libusb/system error code separation is more consistent. The rest of the usbwrap code used exceptions for timeouts, and bool return values for success or failure. So we don't really need to know the exact error code, and if we do, then we already know it is an error state, and TranslateErrcode() can return 0 if it has an "error." For it, the error state is success, since it is meant to return error codes anyway. Since the android/ directory is fairly standalone, I'm considering you as its maintainer. Feel free to push any changes under that directory. As long as I don't see something obvious, I plan to just merge it in, since I don't have a test system to for it yet, and don't really know if it works or not. If it works for you, I want it included. Again, thanks for your work on this! - Chris ------------------------------------------------------------------------------ RSA(R) Conference 2012 Save $700 by Nov 18 Register now http://p.sf.net/sfu/rsa-sfdev2dev1 _______________________________________________ Barry-devel mailing list Barry-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/barry-devel
