bash-completion-Bugs item #313111, was changed at 2012-12-02 02:03 by Igor
Murzov
You can respond by visiting:
https://alioth.debian.org/tracker/?func=detail&atid=413095&aid=313111&group_id=100114
Status: Open
Priority: 3
Submitted By: Sylvestre Ledru (sylvestre)
Assigned to: Nobody (None)
Summary: Please add scilab completion support
Distribution: --Distribution-Agnostic--
Originally reported in: Debian BTS
Milestone: None
Status: None
Original bug number: 575527
Initial Comment:
Hello,
Could you review and apply the attached patch which adds the Scilab completion ?
Thanks
----------------------------------------------------------------------
>Comment By: Igor Murzov (garik-guest)
Date: 2012-12-02 02:03
Message:
I mean that your patch needs to be cleaned up.
> have scilab
This is redundant since bash-completion-2.0.
> COMPREPLY=()
> cur=${COMP_WORDS[COMP_CWORD]}
> prev=${COMP_WORDS[COMP_CWORD-1]}
No need to do these assignments, they were already done in _init_completion.
> # List all options.
> options=$( compgen -W '$( _parse_help "$1" )' -- "$cur" )
$options is assigned a value, but it's never used.
----------------------------------------------------------------------
Comment By: Sylvestre Ledru (sylvestre)
Date: 2012-11-28 13:57
Message:
Igor, could you define what you mean by "messy" ?
----------------------------------------------------------------------
Comment By: Igor Murzov (garik-guest)
Date: 2012-03-14 00:01
Message:
Hi, Sylvestre.
I reviewed your patch and it looks messy, but it's fixable. Anyway, why don't
you ask scilab maintainers to include your completion into scilab itself?
----------------------------------------------------------------------
Comment By: Sylvestre Ledru (sylvestre)
Date: 2012-03-11 14:21
Message:
ping ?
----------------------------------------------------------------------
Comment By: Sylvestre Ledru (sylvestre)
Date: 2011-06-20 15:24
Message:
Thanks for your comments!
Here is an updated patch taking in account your comments.
----------------------------------------------------------------------
Comment By: Sylvestre Ledru (sylvestre)
Date: 2011-05-20 16:31
Message:
Hello,
thanks for all your comments!
I will have a look to fix all the issues.
----------------------------------------------------------------------
Comment By: Ville Skyttä (scop-guest)
Date: 2011-05-17 21:26
Message:
Potential and actual problems:
1) If the text in the license header is correct and the file is indeed part of
Scilab, I see little reason to include it also as part of bash-completion
especially because it doesn't seem to be using any bash-completion features
except _filedir.
2) Even though I guess the CeCILL v2 license and the GPL v2+ of bash-completion
are compatible, the license header seems to imply that we should be including
the CeCILL v2 license text also with bash-completion. I think it'd be better if
the file was licensed under GPL v2+ like the rest of bash-completion if it is
to be included.
3) The file should be changed to use _init_completion, see current
bash-completion git.
4) Current bash-completion git no longer defines $filenames. _filedir turns on
-o filenames automatically when needed.
5) I don't think there's any reason to use grep with compgen -W, just use
compgen -W "$options" -- "$cur"
6) There's no need to include upper and lowercase stuff in _filedir argument
like the completion does, lowercase is enough.
7) Have you looked into using _parse_help or _parse_usage instead of hardcoding
lists of available options?
8) "# List all options. Note that" -- note what?
----------------------------------------------------------------------
You can respond by visiting:
https://alioth.debian.org/tracker/?func=detail&atid=413095&aid=313111&group_id=100114
_______________________________________________
Bash-completion-devel mailing list
Bash-completion-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/bash-completion-devel
