On Thursday 25 March 2010 12:37:13 am Kelvie Wong wrote: > Sorry guys, it's been really busy over here. Anyone want to take a > look at these (really old) patches that I found in my mailbox from a > while back? > >
I pushed these to gitorious just now.
> ---------- Forwarded message ----------
> From: Olivier Rollet <o.rol...@gmail.com>
> Date: 1 February 2010 10:17
> Subject: Re: [Basket-devel] patch for consistency in font names when
> editing tags
> To: Kelvie Wong <kel...@ieee.org>
>
>
> Hello,
>
>
> I'm sending you the patches formatted with git forma-patch,
>
>
> Regards,
>
>
> Olivier Rollet
>
> On Sat, Jan 30, 2010 at 7:54 PM, Kelvie Wong <kel...@ieee.org> wrote:
> > 2010/1/26 Olivier Rollet <o.rol...@gmail.com>:
> >> diff --git a/src/tagsedit.cpp b/src/tagsedit.cpp
> >> index 17b231e..e1d5d18 100644
> >> --- a/src/tagsedit.cpp
> >> +++ b/src/tagsedit.cpp
> >> @@ -1139,6 +1139,7 @@ void TagsEditDialog::ensureCurrentItemVisible()
> >>
> >> void TagsEditDialog::loadBlankState()
> >> {
> >> + QFont defaultFont;
> >> m_stateName->setText("");
> >> m_emblem->resetIcon();
> >> m_removeEmblem->setEnabled(false);
> >> @@ -1148,7 +1149,8 @@ void TagsEditDialog::loadBlankState()
> >> m_italic->setChecked(false);
> >> m_strike->setChecked(false);
> >> m_textColor->setColor(QColor());
> >> - m_font->setCurrentIndex(0);
> >> + //m_font->setCurrentIndex(0);
> >> + m_font->setCurrentFont(defaultFont.family());
> >> m_fontSize->setCurrentIndex(0);
> >> m_textEquivalent->setText("");
> >> m_onEveryLines->setChecked(false);
> >> @@ -1171,8 +1173,11 @@ void TagsEditDialog::loadStateFrom(State *state)
> >> m_textEquivalent->setText(state->textEquivalent());
> >> m_onEveryLines->setChecked(state->onAllTextLines());
> >>
> >> + QFont defaultFont;
> >> +
> >> if (state->fontName().isEmpty())
> >> - m_font->setCurrentIndex(0);
> >> + //m_font->setCurrentIndex(0);
> >> + m_font->setCurrentFont(defaultFont.family());
> >> else
> >> m_font->setCurrentFont(state->fontName());
> >>
> >> ------------------------------------------------------------------------
> >> ------ The Planet: dedicated and managed hosting, cloud storage,
> >> colocation Stay online with enterprise data centers and the best
> >> network in the business Choose flexible plans and management services
> >> without long-term contracts Personal 24x7 support from experience
> >> hosting pros just a phone call away. http://p.sf.net/sfu/theplanet-com
> >> _______________________________________________
> >> Basket-devel mailing list
> >> Basket-devel@lists.sourceforge.net
> >> https://lists.sourceforge.net/lists/listinfo/basket-devel
> >
> > Sorry for getting back to you so late; these patches look good.
> >
> > Could you make a commit (with a message), and use git format-patch to
> > format patches, and send those instead?
> >
> > http://git-scm.com/ has instructions for doing so on the main page.
> >
> > Thanks.
> > --
> > Kelvie Wong
--
Matt
signature.asc
Description: This is a digitally signed message part.
------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev
_______________________________________________ Basket-devel mailing list Basket-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/basket-devel
