DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT <http://issues.apache.org/bugzilla/show_bug.cgi?id=38785>. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=38785 Summary: strange looking equals Product: Batik Version: 1.6 Platform: All OS/Version: other Status: NEW Severity: normal Priority: P2 Component: CSS AssignedTo: [email protected] ReportedBy: [EMAIL PROTECTED] in batik.css.engine.sac.AbstractElementSelector i found an equals-method like this: public boolean equals( Object obj ) { if ( obj == null || !( obj.getClass() != getClass() )) { return false; } ... other comparisons ... The double negated class-compare doesnt make sense to me. The intention seems to be to reject checks against other classes. I 'd do it with instanceof. The same code exists in AbstractAttributeCondition, AbstractCombinatorCondition, AbstractDescendantSelector, AbstractSiblingSelector, CSSConditionalSelector, CSSLangCondition. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
