Jeremias Maerki:
> you are now a committer in Batik. You can apply these changes yourself
> if you think they don't need to be discussed (commit-review). The
> approach you've chosen is only necessary if you have a change that could
> be subject for discussion (review-commit).
Oh and another thing I meant to mention, Dieter. Any file that you make
any changes to (that aren’t trivial reformatting or something similarly
small) should have its copyright message updated so that the current
year is included.
One thing in the code:
Index: org/apache/batik/css/engine/StringIntMap.java
…
- if (count++ >= (len * 3) >>> 2) {
+ if (count++ >= len - ( len >>> 2 )) {
Note that these two expressions are slightly different. For example
when len == 5, the first expression checks >= 3, while the second checks
>= 4. It doesn’t really matter in this case, though, since it’s just
used as a rough check for when the hash table is getting full. If you
realised this, don’t mind me.
Thinking aloud: should we have a code style policy, as FOP does?
--
Cameron McCormack, http://mcc.id.au/
xmpp:[EMAIL PROTECTED] ▪ ICQ 26955922 ▪ MSN [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
