Hi Cameron,
Cameron McCormack <[EMAIL PROTECTED]> wrote on 08/15/2006 03:15:35 AM:
> Thomas DeWeese:
> > I've noticed that the anim code doesn't currently compile under
JDK
> > 1.3.
>
> I probably should try compiling with 1.3 more often!
It's becoming increasingly difficult to keep my development on 1.3.
> > I've fixed a couple of the problems but there are two major issues:
> >
> > 1) The use of LinkedHashSet in the batik.anim.timing.TimeContainer.
> > This is tricky since we want the 'quick' removal. However I
> > think we probably need to just switch to a simple LinkedList
> > perhaps with a matching set (to avoid duplicate adds,
> > I'm not sure if this can happen).
>
> Yeah, I think with normal operation that TimedElements won?t ever be
> added more than once. I?d be happy with it just being a LinkedList.
The other option would be to roll our own doubly linked list with
the TimedElements being the nodes which would allow constant time
removal (and would in fact be slightly better than the LinkedHashSet).
[RANT: It's always annoyed me that they don't open up the Nodes in the
JDK linked list implementation].
> > 2) The use of 'RuntimeException' with the 'cause' Throwable.
> > This isn't available in 1.3. We could subclass or just use
> > the 'causes' message to fill the RuntimeException.
>
> Those in JSVGViewerFrame?
Yes all in JSVGViewerFrame.
> I guess those exceptions should never be thrown in normal operation
> anyway. In general I would prefer to keep the cause, but for these
> I don?t really mind; using the message should be fine.
I agree, having the cause is great, but JDK 1.3 doesn't easily
let us keep this. So I'll switch the code over to 'getMessage'.
I'll try and keep some indicator that these should be updated if
we ever jump base JDK versions.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
