Hi,
Second version of the patch fix the problem. As said in bugzilla, it was
due to a typo in some code retrieving the clipping coordinates for
texts, in theWMFPainter class. This bug was introduced before this patch
(good chance it was my fault), but I don't know when...
Hervé
[EMAIL PROTECTED] wrote:
Hi all,
I've applied the patches I could. I ran into problems with 41205 as
the
WMF files did not render the same as SVG as they did WMF. I'd like
to give a Herve a day to look into this/respond but it isn't a big deal
for me one
way or the other.
I think I've fixed the 'Missing Resource Bundle' problem the correct
way
(LocalizableSupport can now walk the class tree looking for a
ResourceBundle
with the needed key), some care was taken to keep performance similar in
similar
situations.
I've updated the reference images that had 'trivial' differences on my
machine.
The only issue I have is that some of the memory leak tests are still
failing.
I haven't had much time to look into possible reasons for false
positive's.
Cameron and Dieter have either of you?
In any case I think we can go ahead with the RC in the next day or two.
I think it will be best to treat the RC as a real release, but I don't
think we
should advertise it outside of the Batik Mail-lists.
Lots of hard work went into this, cheers all around!!!
Cameron McCormack <[EMAIL PROTECTED]> wrote on 01/27/2007 03:15:00 AM:
Thomas DeWeese:
Here is my list, I'm applying them locally (any opinions
on 41216).
40681 - Patch already provided (thanks to Archie).
41205 - Patch already provided (thanks to Herve).
I didn?t review the patches, but if you?re happy with them that?s fine.
41216 - Patch is available, (thanks to Trejkaz) I don't think
we have a CLA but the patch is basically just adding
all the other charsets.
Yeah I?m a bit worried the patch is too large to accept without a CLA.
Did you contact Trejkaz about it?
41234 - We should try and make sure the resource files
for errors can be found (this has popped up in a few
places).
The simple fix may be to just replicating the
Messages.properties to the new directory. I actually
think our whole messaging system needs some work.
I?m happy with that as a stop-gap solution. (I guess Jeremias could do
that too for FOP?s related problem, before a proper solution is made.)
So after these changes, I guess we?re done, and a release candidate can
be made. I?ll collate the bugs in Bugzilla that have been closed since
the 1.6 release so that they can be included in the README file in the
distribution directory.
I read through some messages before 1.6?s release, and noted that even
a RC must go through the formal process of getting a vote from the PMC.
That?d be the next step then?
--
Cameron McCormack, http://mcc.id.au/
xmpp:[EMAIL PROTECTED] ? ICQ 26955922 ? MSN [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
