https://issues.apache.org/bugzilla/show_bug.cgi?id=46072
G. Wade Johnson <[EMAIL PROTECTED]> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |[EMAIL PROTECTED]
--- Comment #3 from G. Wade Johnson <[EMAIL PROTECTED]> 2008-10-29 15:21:14
PST ---
(In reply to comment #2)
> (In reply to comment #1)
> > Created an attachment (id=22786)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=22786) [details]
[details]
> > First attempt patch to allow changing location with script.
>
> Cool! :-)
>
>
>
> > + * @version $Id: Loaction.java$
>
> Sounds like a typo.
Yeah. I've changed my copy. I'll send a new patch once I've got the
LocationWrapper thing worked out.
>
> > null == location
>
> I'd suggest the reverse (location == null) as it's more intuitive and seems to
> match the code
Since 'location == null' seems to be the convention, I'll switch to that. But
as an old C, C++, etc. programmer I'd argue that it's not more "intuitive".
(Then again, I've been known to argue that nothing in programming is intuitive,
but that's another discussion.<grin/>)
> > + * @param url A string containing the URL where the user agent should
> > + * navigate.
>
> "should navigate [to]."? ;-)
I was trying to avoid that for more formal English, but it does make more
sense.
I've changed it in my copy.
> > However, this is functional and some feedback/review of the implementation
> > is
> > appreciated.
>
> Intuitively it looks well, and I may help testing whenever/if this makes it
> into the trunk and/or if someone with more expertise (such as Cameron or
> Thomas, for example) states this looks good enough (by applying the patch
> locally). Sorry for not being able to provide a deeper review but I'm not that
> familiar with Batik codebase yet. ;-)
Thank you for the help. As I said, I'll have a new patch soon.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
