https://issues.apache.org/bugzilla/show_bug.cgi?id=46926





--- Comment #2 from Helder Magalhães <[email protected]>  2009-03-27 
09:01:13 PST ---
(In reply to comment #1)
> Created an attachment (id=23422)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=23422) [details]
> Patch version 2

-        <javac srcdir="${src}" destdir="${build.classes}" />
+        <javac srcdir="${src}" destdir="${build.classes}" debug="true">
+            <classpath>
+                <pathelement location="../../classes"/>
+                <fileset dir="." includes="lib/**/*.jar"/>
+            </classpath>
+        </javac>

>From the main "build.xml" file:

  If you are going to be doing development you may want to create a file
  called 'build.properties' with the line 'debug=on' in it.  This will 
  turn on the generation of debugging information when compiling Batik.

I'm not sure if it would be a good idea to make this here also but, at least,
creating a property "debug" and using 'debug="${debug}"' instead (for coherency
with the main build file) looked like a good idea. :-)


> I've also taken up Helder's vote for compatibility, and added a flatten
> attribute defaulting to true.

Great! :-)  Not breaking existing work is, IMHO, a good approach in general.
;-)


Finally, I believe the patch should also address some documentation regarding
the newly introduced features. (The documentation source for that is
"rasterizer.xml" [1] which, after published, should appear at "rasterizer.html"
[2].

[1] documentation-sources/content/xdocs/tools/rasterizer.xml
[2] http://xmlgraphics.apache.org/batik/tools/rasterizer.html#task

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to