https://issues.apache.org/bugzilla/show_bug.cgi?id=47359





--- Comment #13 from Nicolas Socheleau <[email protected]>  
2009-06-16 13:28:13 PST ---
> 
> Apparently not those two items. ;-)

I hope I got it right this time :)

> > +                    for(int k = 0; k < values.size(); k++)
> > +                    {
> > +                        Object baselineValue = values.get(k);
> 
> Could/should the "Object" variable be moved to outside the cycle? Although the
> nesting will probably never be more than one level...

I moved it outside of the loop

> > +         //for the child of the element
> 
> Seems that a superfluous (indenting) space slipped into that line. ;-)
> 
you got me!

> > I've attached test file for animation and scripting as well for the review.
> 
> Cool, I noticed the attachments but didn't have the chance to test them yet.
> Nevertheless, you didn't state whether the patch properly handled those
> situations (although you working suggests so).
> 

the scripting and animation test files are working with the patch. Though, I'm
still working on some other animations where I don't get what I expect. 
I'm starting to fix it is a different issue. I'll keep digging...

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to