https://issues.apache.org/bugzilla/show_bug.cgi?id=49968
Helder Magalhães <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|GVT |GVT Text --- Comment #1 from Helder Magalhães <[email protected]> 2010-09-22 05:17:50 EDT --- (In reply to comment #0) > Created an attachment (id=26061) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=26061) [details] > Patch to improve font matching Cool stuff. Thanks, Jeremias! ;-) > 3. Handle the case where a font family with spaces contains an integer value > (ex. "Univers 45 Light"), but is not in quotes (FontFamilyManager). Does this mean that bug 44828 gets fixed by this as well? :-) (from the patch) + //Also register all font names, not just font families. + //Example: Font Family: "Univers", but Font Name: "Univers 45 Light" + //Without this, matching "Univers 45 Light" is not possible. + Font[] allFonts = env.getAllFonts(); + for (int i = 0; i < allFonts.length; i++) { + Font f = allFonts[i]; + fonts.put(f.getFontName().toLowerCase(), f.getFontName()); + } Does this mean that bug 46374 gets fixed by this as well? :-) Generally, the patch looks good to me. Thomas, could you also take a look and state whether this is ready to land or if anything else is needed (tests for regard, etc.)? -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
