https://issues.apache.org/bugzilla/show_bug.cgi?id=50006
--- Comment #4 from Helder Magalhães <[email protected]> 2010-09-28 01:52:30 EDT --- (In reply to comment #3) > Hrm, looks like getLeft()/getRight() return a glyph ID(?) instead of the > Unicode codepoint as I thought. Nice catch. :-) > There's probably a better way to map the glyph ID back to the corresponding > codepoint but I was unable to find it. The code sounds fine, I'm just thinking a bit about performance. I've noticed you using TreeSet which, according to the documentation, isn't bad: "This implementation provides guaranteed log(n) time cost for the basic operations (add, remove and contains)." [1] I'm thinking a bit about this in the sense that Unicode fonts may have a very large set of characters, where then performance can be a bit noticeable. I couldn't easily find a better suited replacement. Maybe Thomas/Cameron/DVHolten can shed some light in here? Apart from that potential improvement (regarding set management), the code looks hood and ready to land IMO. ;-) [1] http://download.oracle.com/javase/6/docs/api/java/util/TreeSet.html -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
