[
https://issues.apache.org/jira/browse/BATIK-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13599511#comment-13599511
]
Thomas DeWeese commented on BATIK-1041:
---------------------------------------
Please don't rearrange the imports (org.w3c should not come after org.apache),
if you really want to change the import order you would need to do it for _all_
source files not just the ones in the diff (and it should be a separate diff).
Please don't add a constructor to UserAgentAdaptor that takes
FontFamilyResolver, the whole point of an Adaptor is to not need to specify
anything and get reasonable behavior so you can subclass and override the
methods you care about (this also means removing the member).
In sources/org/apache/batik/bridge/SVGTextElementBridge.java
I don't care for the inversion between
fontFamilyResolver.resolve(FontFamily) and
fontFamily.resolve(FontFamilyResolver).
I also don't care for using ?: where an if would be fine.
This patch doesn't seem very complete since the stroking text painter doesn't
get it's font family resolver from the bridge or the user agent. Batik still
uses the stroking text painter for any "non trivial" piece of text, this would
seem to be a problem wouldn't it?
> Make it possible to plug custom FontFamilyResolver
> --------------------------------------------------
>
> Key: BATIK-1041
> URL: https://issues.apache.org/jira/browse/BATIK-1041
> Project: Batik
> Issue Type: Improvement
> Reporter: Vincent Hennebert
> Attachments: FontFamilyResolver.diff
>
>
> This patch turns FontFamilyResolver into an interface and moves the current
> code into a default implementation. It also adds a getFontFamilyResolver to
> StrokingTextPainter that can be overridden in order to provide a custom
> implementation.
> This allows to use fonts from other libraries than AWT. In fact, AWT fonts
> can be totally disabled if necessary.
> This patch is experimental and should be put in a branch. Further updates are
> to be expected.
> This is a joint work from Peter Hancock and me.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
