[ 
https://issues.apache.org/jira/browse/BATIK-1197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16119557#comment-16119557
 ] 

Thomas Mortagne edited comment on BATIK-1197 at 8/9/17 8:45 AM:
----------------------------------------------------------------

bq. The jython/rhino dependencies have been there a long time

Not sure what you mean exactly. You did not ended up with Jython with 1.9 or 
previous versions. Sure it was possible to use Jython if you added the JAR 
yourself as indicated on https://xmlgraphics.apache.org/batik/install.html but 
it was not a mandatory dependency from Maven point of view.

There is nothing about Jython or Rhino in 
https://www.mail-archive.com/batik-users@xmlgraphics.apache.org/msg10017.html 
so I don't understand where exactly "as suggested" come from.

It's not all or nothing, since those dependencies can be used it sure make sens 
to declare them as dependencies but they could be optional dependencies. Jython 
JAR is really not a details (it's big and wrongly embed lots of other 
libraries) especially when it's used for pretty edge cases when you are a FOP 
user. Excluding a dependency is always a hack and there is nothing telling you 
that batik-script is and will continue to work without it.

bq. Excluding jython seems to work

Yes but I'm trying to understand why this dependency suddenly became non 
optional and this upgrade is not critical for me right now. Also the fact that 
there is no 1.9.1 version in Jira or 
http://svn.apache.org/repos/asf/xmlgraphics/batik/tags/ did not really 
reassured me on the quality of this release so I wanted to make sure all that 
really was intended and not a mistake. Adding such big dependencies in a minor 
version is quite weird.


was (Author: tmortagne):
bq. The jython/rhino dependencies have been there a long time

Not sure what you mean exactly. You did not ended up with Jython with 1.9 or 
previous versions. Sure it was possible to use Jython if you added the JAR 
yourself as indicated on https://xmlgraphics.apache.org/batik/install.html but 
it was not a mandatory dependency from Maven point of view.

There is nothing about Jython or Rhino in 
https://www.mail-archive.com/batik-users@xmlgraphics.apache.org/msg10017.html 
so I don't understand where exactly "as suggested" come from.

It's not all or nothing, since those dependencies can be used it sure make sens 
to declare them as dependencies but they could be optional dependencies. Jython 
JAR is really not a details (it's big and wrongly embed lots of other 
libraries) especially when it's used for pretty edge cases when you are a FOP 
user. Excluding a dependency is always a hack and there is nothing telling you 
that batik-script is and will continue to work without it.

bq. Excluding jython seems to work

Yes but I'm trying to understand why this dependency suddenly became non 
optional and this upgrade is not critical for me right now. Also the fact that 
there is no 1.9.1 version in Jira or 
http://svn.apache.org/repos/asf/xmlgraphics/batik/tags/ did not really 
reassured me on the quality of this release so I wanted to make all that really 
was intended and not a mistake. Adding such big dependencies in a minor version 
is quite weird.

> Non optional dependencies on jython and rhino added in 1.9.1
> ------------------------------------------------------------
>
>                 Key: BATIK-1197
>                 URL: https://issues.apache.org/jira/browse/BATIK-1197
>             Project: Batik
>          Issue Type: Bug
>          Components: Scripting
>            Reporter: Thomas Mortagne
>
> Note: can't find the 1.9.1 version so I did not set it in "Affects Version/s".
> Looks like a big change for a minor version. Is this really expected ?
> Maybe 1.9.1 was release by mistake ? I can only see it in Maven central but 
> can't find a version here on any corresponding tag in 
> http://svn.apache.org/repos/asf/xmlgraphics/batik/tags/



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: batik-dev-unsubscr...@xmlgraphics.apache.org
For additional commands, e-mail: batik-dev-h...@xmlgraphics.apache.org

Reply via email to