Re: getStyle in StylableExtensionElement

[Guillaume Pothier]

Yeah, I looked at the SVGStylableElement implementation, and my first 
reaction was to copy/paste the method body to my subclass, but then I 
noted that there is also a quite big inner class to copy, so I didn't go on.
Are you going to implement to change you mentioned?
Thx
Guillaume

Thomas DeWeese wrote:
Guillaume Pothier wrote:

Hi!

The current implementation of getStyle () in 
org.apache.batik.extension.StylableExtensionElement is as follows 
(nightly cvs):

 public CSSStyleDeclaration getStyle() {
        throw new InternalError("Not implemented");
    }
Is this the intended behaviour? I mean, should every subclass 
implement getStyle in its own way, or dos "Not implemented" means "Not 
implemented yet"?


  It isn't 100% clear to me why this is done.  If you look in
batik.dom.svg.SVGStylableElement you can see a pretty good
implementation of getStyle.  I would be tempted to make
the ExtensionElement a subclass of SVGStylable.  You will however
notice that there are a couple of SVG specific things in that
implementation (most notably the handling of paint/color properties).




---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]