On Wed, 2005-02-09 at 10:05 -0500, Steven Huey wrote: > Thomas, > > If you query the System properties for "os.name" on Mac OS X the > resulting String is "Mac OS X". You could check that when setting the > ColorModel to make the code Mac specific.
remember us running inside a SecurityManager :-P (check java.lang.SecurityException) > > - Steve > > On Feb 9, 2005, at 6:04 AM, Thomas DeWeese wrote: > > > Hi Steven, > > > >> Steven Huey wrote: > >>> 2. Why is sRGB_Unpre selected as the default? > > > > Thomas DeWeese wrote: > > > >> This is complex, there used to be lots of 'gotchas' in > >> Java2D (but this was mostly back with JDK 1.2), so it is > >> entirely possible that it was chosen as the least bug prone > >> choice (which makes me nervous to change it), and on Unix > >> and windows the performance difference was negligible. > >> Obviously, the above means that this should probably change > >> I'll look at changing it and see what breaks. > > > > Bad news an old bug decided to come back from the dead. > > When you clip the rendering the sRGB_Pre code path sometimes > > comes up with a zero height clip region which causes the > > code to keel over (doesn't happen with Unpre). > > > > The good news is that this bug seems to be fixed in JDK 1.4, > > so I may make the ColorModel used depend on the JDK version > > (the Mac JVM is 1.4). This still makes me nervous because it > > means that there will be a very significant difference between > > how images are rendered in JVM's >= 1.4 from 1.3. > > > > I could also make it Mac specific, this would be safer since > > without the change Batik is almost unusable on Mac anyways so some > > fairly small chance of additional problems is less of an issue. > > > > --- > > > > > >>> I checked out the Batik sources from CVS and changed line 90 that > >>> reads: > >>> > >>> ColorModel cm = GraphicsUtil.sRGB_Unpre; > >>> = PowerBook = > >>> sRGB_Pre: 2.828 > >>> sRGB_Unpre: 133.748 > >> That's pretty impressive :) > > > > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [EMAIL PROTECTED] > > For additional commands, e-mail: [EMAIL PROTECTED] > > > > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] ________________________________________ Robert Marcano web: http://www.marcanoonline.com/ blog: http://www.marcanoonline.com/plog/ --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
