Thomas DeWeese wrote:I think I have a solution to this bug.
Hi Lukasz,
Lukasz Matuszczak wrote:
Thank you very much, Thomas, your solution seems to work.
Good Glad to hear it.
One question on this, what events should be sent? when suspend and resume are called in close proximity (i.e. before the runnable thread actually suspends). Right now no thread events get sent (just like if you call resume when the thread is already running).
I think when we call suspend or resume we should always get managerSuspended and managerResumed events respectively, even if they are called in close proximity
I think it's a little misleading to send a "managerSuspended" event when the manager is still running don't you? Even in the past if you called 'resume' when it was already running no event would be fired. So the answer isn't quite as obvious as one might think.
(unless the manager fails). Does it work this way in a current solution?
No, currently if the runnable queue doesn't actually stop before you call resume it will not send either of the events. What I will probably try and do is have it send a resumed event (which could be considered a failed event for the suspend request). This is a little tricky to do right.
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
