Hello Roland, On 2012-10-16 09:12 +0800, Roland Winkler wrote: >> Recent BBDB3 doesn't allow duplicates by default. It does >> mail-completion from the first record of the duplicates. The >> others are ignored. > > I guess I start to understand, where your problem is coming from. > When BBDB loads the database, bbdb-allow-duplicates is nil, and > there are multiple records with the same name, then only the first > record with this name is hashed (so that it becomes available for > things like completion). While the code relevant for this was broken > in BBDB v2, nonetheless it contained fragments of code and comments > related to this behavior advertising this as intended behavior. > > I think the point is: a variable like bbdb-allow-duplicates should > only affect the creation of new records as well as possibly issuing > a warning if the database contains duplicate records when loaded. > But it should not affect the usage of the records present in the > database for things like completion. Otherwise things get rather > obscured. (You got fooled!) > > I'll change the code accordingly (unless someone tells me there is a > problem I overlooked, or someone proposes a yet better scheme). > >> > I don't have any real-world scenarios to test here. Do you get what >> > you expect to get when bbdb-allow-duplicates is t and you have >> > multiple records with the same name? >> >> Exactly! My BBDB db has records of the same name since a few years ago. > > In my mail yesterday, I only thought of bbdb-complete-mail being > affected by duplicate records. BBDB's MUA interface is actually more > subtle. Here I can think of situations where BBDB can get confused > and give strange results if, say, a message uses a name matching > multiple records, but the email address of the message, does not > match any of these records. - Probably, this is a yet more exotic > situation than multiple records with the same name. Maybe there are > other situations (possibly yet more exotic) affected by this. > > Roland
I hope you have time to fix these problems ;) Thanks, Leo ------------------------------------------------------------------------------ Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft MVPs and experts. SALE $99.99 this month only -- learn more at: http://p.sf.net/sfu/learnmore_122912 _______________________________________________ bbdb-info@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/bbdb-info BBDB Home Page: http://bbdb.sourceforge.net/
