On Tuesday, July 15, 2003 at 15:00:51, Robert P. Goldman wrote:
> 
> The following defun in bbdb-sc.el seems buggy:
> 
> (defun bbdb/sc-consult-attr (from)
>   "Extract citing information from BBDB using sc-consult where
> FROM is user e-mail address to look for in BBDB."
>     ;; if logged in user sent this, use recipients.
>     (let ((check (if (or (null from)
>              (string-match (bbdb-user-mail-names) from))
>              (car (cdr (mail-extract-address-components
>                 (or (sc-mail-field "to") from))))
>            from)))
>       (if from
>       (let ((record (bbdb-search-simple nil from)))
>         (and record (bbdb-record-getprop record
>         bbdb/sc-attribution-field))))))
> 
> 
> If you look at the call to STRING-MATCH, the first argument is
> supposed to be a REGEXP and the second a STRING.  But
> (bbdb-user-mail-names) returns a LIST.

IMHO it should not return a list unless you had been setting
`bbdb-user-mail-names' to an list.

Thus I rejected making this change unless convinced of the
opposite ...

Robert



-------------------------------------------------------
This SF.Net email sponsored by: Free pre-built ASP.NET sites including
Data Reports, E-commerce, Portals, and Forums are available now.
Download today and enter to win an XBOX or Visual Studio .NET.
http://aspnet.click-url.com/go/psa00100003ave/direct;at.aspnet_072303_01/01
_______________________________________________
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/bbdb-info
BBDB Home Page: http://bbdb.sourceforge.net/

Reply via email to