On 2011-09-22 17:02 +0800, Roland Winkler wrote:
[snipped 5 lines]
> I am sorry, you have confused me. Which patch are you ultimately
> proposing?
>
> As I mentioned before on this list, I do not know very much about
> Gnus internals. So up to now I haven't done much to clean up /
> update BBDB's Gnus interface. If anyone more knowledgeable than
> myself could look into this, that would be great.
>
> Roland

BTW, I guess gnus-Group-mode gnus-Subject-mode gnus-Article-mode were
names used in the original GNUS i.e. before Lars rewrote it. They are no
longer used.

I propose this patch:

commit ea095835e8970811f71eb617147206ba14916ab6
Date:   Thu Sep 22 08:53:25 2011 +0800

    Remove erroneous and useless gnus code in bbdb-pop-up-window
---
 lisp/bbdb.el |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

        Modified lisp/bbdb.el
diff --git a/lisp/bbdb.el b/lisp/bbdb.el
index afc102e9..087c9191 100644
--- a/lisp/bbdb.el
+++ b/lisp/bbdb.el
@@ -2608,9 +2608,6 @@ (defun bbdb-pop-up-window (&optional select horiz-p)
                            (max window-min-height bbdb-pop-up-window-size))
                       (round (* bbdb-pop-up-window-size
                                 (window-height tallest-window)))))
-                   (if (memq major-mode
-                             '(gnus-Group-mode gnus-Subject-mode 
gnus-Article-mode))
-                       (goto-char (point-min)))  ; make gnus happy...
                    (select-window (next-window)) ; goto the bottom of the 
two...
                    (let (pop-up-windows)         ; make it display *BBDB*...
                      (switch-to-buffer (get-buffer-create bbdb-buffer-name))))



------------------------------------------------------------------------------
All the data continuously generated in your IT infrastructure contains a
definitive record of customers, application performance, security
threats, fraudulent activity and more. Splunk takes this data and makes
sense of it. Business sense. IT sense. Common sense.
http://p.sf.net/sfu/splunk-d2dcopy1
_______________________________________________
bbdb-info@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bbdb-info
BBDB Home Page: http://bbdb.sourceforge.net/

Reply via email to