On Fri Jul 20 2012 Roland Winkler wrote:
> On Fri Jul 20 2012 Roland Winkler wrote:
> > On Fri Jul 20 2012 Stefan Monnier wrote:
> > > What I'm saying is that it's tricky to use
> > > Electric-command-loop without introducing bugs because
> > > Electric-command-loop presumes that all operations will stay
> > > within the current buffer, but it does not (help to) try to
> > > enforce it. So it's a poor API.
> > 
> > I do not disagree here. I got into all this business because the
> > Electric-command-loop has been present in old versions of BBDB. But
> > I would not miss it, if it disappeared. (I do not even know whether
> > any other BBDB user would miss it. I'll ask on the BBDB mailing
> > list.)
> 
> BBDB uses Electric-command-loop to provide an `electric' version of
> BBDB. Is anyone using this?
> 
> Recently Electric-command-loop has been discussed on the
> bug-gnu-emacs list (see bug#11983), pointing out some basic design
> flaws it has. Would anyone miss the electric version of BBDB if it was
> removed completely?

I think that removing the electric command loop does not remove any
useful functionality from BBDB.

The second patch ensures proper cleanup after using
bbdb-complete-mail with a *Completions* buffer.

2012-08-11  Roland Winkler  <wink...@gnu.org>
        Remove electric mode that was not providing any new functionality
        to BBDB.  Also see GNU Emacs Bug#11983.

        * lisp/bbdb.el (bbdb-electric, bbdb-inside-electric-display)
        (bbdb-quit-window, bbdb-electric-display-records)
        (bbdb-electric-throw, bbdb-quit-window)
        (bbdb-display-records-internal): Remove.
        (bbdb-display-records): Remove arg electric.  Merge with
        bbdb-display-records-internal.
        (bbdb-redisplay-records): Use bbdb-display-records.

        * lisp/bbdb-com.el (bbdb-mail, bbdb-mail-address, bbdb-info):
        Remove electricity.
        (bbdb-mail-abbrev-expand-hook): Use bbdb-display-records.

        * lisp/bbdb-mua.el (bbdb-mua-display-records)
        (bbdb-mua-auto-update): Use bbdb-display-records.

2012-08-11  Roland Winkler  <wink...@gnu.org>
        * lisp/bbdb-com.el (bbdb-complete-mail-cleanup): New function.
        (bbdb-complete-mail): Use it.  In particular, clean up also when
        using *Completions* buffer.


------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
bbdb-info@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bbdb-info
BBDB Home Page: http://bbdb.sourceforge.net/

Reply via email to