"Roland Winkler" <wink...@gnu.org> writes:
> Great, thank you, your new approach should work for everyone.
> Two minor things:
>
> - In bbdb-site.el.in, you kept the value of bbdb-print-tex-path
> '("/usr/local/share"). This seems to be a typo that has been
> there for some time and should probably be replaced by
> '("/usr/local/share/bbdb") because lisp/bbdb-print.el does not add
> any other prefix to bbdb-print-tex-path. (Previously, you made
> some comments in this context, which I did not understand. Was
> this typo in bbdb-site.el.in what you refered to?)
Yes.
Fixed. (Replaced with @xxx@ for clarity.)
> - lisp/Makefile.am calls sed with the option `--expression'. Will
> this work reliably on different unix-like systems? Or would it be
> more reliable to use `-e' instead? (In my personal shell scripts
> I certainly prefer the long option names. But that's a different
> story.)
Fixed.
I looked up the automake incantations to cause bbdb-site.el to be
rebuilt following ./configure, built early, and distributed in the
tarball.
Whether to include bbdb-site.el and bbdb-pkg.el in the git repo is a
policy question for you.
PROs: Would helpful for elpa-like mechanisms which use the git repo
rather than the distribution tarball. That's how MELPA works, and MELPA
has icky @xxx@ crud in its bbdb-site.el which putting a generated
bbdb-site.el into the repo should solve.
CONs: Confusion when the generated version shows up as modified due to
local configuration, tempting people to commit the change. Violation of
"no generated files in repo" rule of thumb. Must remember to regenerate
and commit with default "./configure ; make" options when .in files are
changed, the version is bumped, and maybe when PACKAGE_DATE changes.
--Barak.
------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and their
applications. Written by three acclaimed leaders in the field,
this first edition is now available. Download your free book today!
http://p.sf.net/sfu/13534_NeoTech
_______________________________________________
bbdb-info@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bbdb-info
BBDB Home Page: http://bbdb.sourceforge.net/
