Author: dbrosius
Date: Sun Jul 31 17:23:35 2005
New Revision: 226705
URL: http://svn.apache.org/viewcvs?rev=226705&view=rev
Log:
improve string appending performance in loops
Modified:
jakarta/bcel/trunk/src/java/org/apache/bcel/verifier/structurals/LocalVariables.java
jakarta/bcel/trunk/src/java/org/apache/bcel/verifier/structurals/OperandStack.java
Modified:
jakarta/bcel/trunk/src/java/org/apache/bcel/verifier/structurals/LocalVariables.java
URL:
http://svn.apache.org/viewcvs/jakarta/bcel/trunk/src/java/org/apache/bcel/verifier/structurals/LocalVariables.java?rev=226705&r1=226704&r2=226705&view=diff
==============================================================================
---
jakarta/bcel/trunk/src/java/org/apache/bcel/verifier/structurals/LocalVariables.java
(original)
+++
jakarta/bcel/trunk/src/java/org/apache/bcel/verifier/structurals/LocalVariables.java
Sun Jul 31 17:23:35 2005
@@ -181,11 +181,14 @@
* Returns a String representation of this object.
*/
public String toString(){
- String s = new String();
+ StringBuffer sb = new StringBuffer();
for (int i=0; i<locals.length; i++){
- s += Integer.toString(i)+": "+locals[i]+"\n";
+ sb.append(Integer.toString(i));
+ sb.append(": ");
+ sb.append(locals[i]);
+ sb.append("\n");
}
- return s;
+ return sb.toString();
}
/**
Modified:
jakarta/bcel/trunk/src/java/org/apache/bcel/verifier/structurals/OperandStack.java
URL:
http://svn.apache.org/viewcvs/jakarta/bcel/trunk/src/java/org/apache/bcel/verifier/structurals/OperandStack.java?rev=226705&r1=226704&r2=226705&view=diff
==============================================================================
---
jakarta/bcel/trunk/src/java/org/apache/bcel/verifier/structurals/OperandStack.java
(original)
+++
jakarta/bcel/trunk/src/java/org/apache/bcel/verifier/structurals/OperandStack.java
Sun Jul 31 17:23:35 2005
@@ -185,11 +185,19 @@
* Returns a String representation of this OperandStack instance.
*/
public String toString(){
- String s = "Slots used: "+slotsUsed()+" MaxStack:
"+maxStack+".\n";
+ StringBuffer sb = new StringBuffer();
+ sb.append("Slots used: ");
+ sb.append(slotsUsed());
+ sb.append(" MaxStack: ");
+ sb.append(maxStack);
+ sb.append(".\n");
for (int i=0; i<size(); i++){
- s+=peek(i)+" (Size: "+peek(i).getSize()+")\n";
+ sb.append(peek(i));
+ sb.append(" (Size: ");
+ sb.append(String.valueOf(peek(i).getSize()));
+ sb.append(")\n");
}
- return s;
+ return sb.toString();
}
/**
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
